src/configurations/destinations/accoil_analytics/db-config.json (2)

14-14: Consider documenting the empty excludeKeys array

The excludeKeys array is empty. If this is intentional, consider adding a comment in the documentation PR (rudderlabs/rudderstack-docs#1196) explaining why no keys need to be excluded for this destination.

---

44-115: Consider reducing configuration duplication

The platform-specific configurations contain identical settings for most platforms. Consider refactoring to use a common configuration template to improve maintainability.

 "destConfig": {
   "defaultConfig": ["apiKey", "blacklistedEvents", "whitelistedEvents", "eventFilteringOption"],
+  "commonConfig": [
+    "connectionMode",
+    "consentManagement",
+    "oneTrustCookieCategories",
+    "ketchConsentPurposes"
+  ],
   "web": [
     "useNativeSDK",
-    "connectionMode",
-    "consentManagement",
-    "oneTrustCookieCategories",
-    "ketchConsentPurposes"
+    ...commonConfig
   ],
   // Apply similar pattern to other platforms

src/configurations/destinations/accoil_analytics/ui-config.json (3)

60-64: Clarify purpose of empty SDK Template.

The SDK template section is marked as "not visible in the ui" and contains no fields. If this section is not needed, consider removing it to avoid confusion in future maintenance.

---

81-92: Simplify duplicate feature flag conditions.

The OneTrust and Ketch sections have identical feature flag conditions. Consider extracting these to a shared configuration to improve maintainability.

+ "consentFeatureFlags": {
+   "featureFlags": [
+     {
+       "configKey": "AMP_enable-gcm",
+       "value": false
+     },
+     {
+       "configKey": "AMP_enable-gcm"
+     }
+   ],
+   "featureFlagsCondition": "or"
+ },

Then reference this shared configuration in both sections.

Also applies to: 106-117

---

172-173: Fix inconsistent apostrophe usage.

Change ID's to IDs for consistency with other occurrences in the file.

-"label": "Enter consent category ID's",
+"label": "Enter consent category IDs",

src/configurations/destinations/accoil_analytics/schema.json (2)

7-10: Consider strengthening the API key pattern validation

The current pattern (^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{1,100})$ allows any string up to 100 characters. Consider adding more specific validation for the API key format to prevent invalid keys.

       "apiKey": {
         "type": "string",
-        "pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{1,100})$"
+        "pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^([a-zA-Z0-9_-]{32,100})$",
+        "description": "Accoil Analytics API key. Must be 32-100 characters long and contain only alphanumeric characters, underscores, and hyphens."
       }

---

845-858: Consider adding validation for native SDK configuration

The useNativeSDK configuration lacks constraints that might be important:

1. No default values are specified
2. No description of the implications of enabling/disabling native SDK
3. No validation to ensure consistent settings across platforms

    "useNativeSDK": {
      "type": "object",
+     "description": "Configuration for native SDK usage per platform",
      "properties": {
        "web": {
-         "type": "boolean"
+         "type": "boolean",
+         "default": false,
+         "description": "Enable/disable native SDK for web platform"
        },
        "android": {
-         "type": "boolean"
+         "type": "boolean",
+         "default": false,
+         "description": "Enable/disable native SDK for Android platform"
        },
        "ios": {
-         "type": "boolean"
+         "type": "boolean",
+         "default": false,
+         "description": "Enable/disable native SDK for iOS platform"
        }
      }
    }

Configuration used: CodeRabbit UI
Review profile: CHILL

#!/bin/bash
# Check message type configurations in other destinations
rg -A 5 '"supportedMessageTypes"' src/configurations/destinations/

#!/bin/bash
# Check native SDK support patterns in other destinations
rg '"useNativeSDK"' src/configurations/destinations/

#!/bin/bash
# Find and check the corresponding schema file
fd -t f schema.json src/configurations/destinations/accoil_analytics/

#!/bin/bash
# Let's check the schema file for Accoil Analytics specifically
cat src/configurations/destinations/accoil_analytics/schema.json

#!/bin/bash
# Check other destinations for similar settings and any associated privacy controls
rg -l "saveDestinationResponse.*true" src/configurations/destinations/

#!/bin/bash
# Let's search for saveDestinationResponse configuration in other destinations
rg -A 2 '"saveDestinationResponse"' src/configurations/destinations/

#!/bin/bash
# Check if other destinations follow similar pattern
fd -e json -x jq -r 'select(.uiConfig.baseTemplate[].sections[].id == "consentSettings") | input_filename' {} \; 2>/dev/null

#!/bin/bash
# Check for other occurrences of this feature flag
rg -l "AMP_enable-gcm" | xargs jq -r 'paths as $p | select(getpath($p) == "AMP_enable-gcm") | $p | join(".")'

#!/bin/bash
# Description: Check if other destinations support additional connection modes

# Search for connection mode configurations in other destination schemas
fd . src/configurations/destinations -e json -x grep -l "connectionMode"

#!/bin/bash
# Let's check the connection mode configurations in other destination schemas
# We'll sample a few schemas to see if they have different connection modes

# Check Adobe Analytics schema
echo "=== Adobe Analytics Connection Mode ==="
rg -A 10 '"connectionMode":\s*{' src/configurations/destinations/adobe_analytics/schema.json

echo -e "\n=== Zendesk Connection Mode ==="
rg -A 10 '"connectionMode":\s*{' src/configurations/destinations/zendesk/schema.json

echo -e "\n=== Salesforce Connection Mode ==="
rg -A 10 '"connectionMode":\s*{' src/configurations/destinations/salesforce/schema.json

echo -e "\n=== Snowflake Connection Mode ==="
rg -A 10 '"connectionMode":\s*{' src/configurations/destinations/snowflake/schema.json

#!/bin/bash
# Let's fix the regex and check connection modes in other destination schemas

# Check Adobe Analytics schema
echo "=== Adobe Analytics Connection Mode ==="
rg -A 10 '"connectionMode"' src/configurations/destinations/adobe_analytics/schema.json

echo -e "\n=== Zendesk Connection Mode ==="
rg -A 10 '"connectionMode"' src/configurations/destinations/zendesk/schema.json

echo -e "\n=== Salesforce Connection Mode ==="
rg -A 10 '"connectionMode"' src/configurations/destinations/salesforce/schema.json

echo -e "\n=== Snowflake Connection Mode ==="
rg -A 10 '"connectionMode"' src/configurations/destinations/snowflake/schema.json

src/configurations/destinations/accoil_analytics/schema.json (1)

796-844: Simplify connection mode configuration

The connection mode configuration can be simplified since all platforms use the same "cloud" enum.

Apply this refactor:

{
  "configSchema": {
    "properties": {
      "connectionMode": {
        "type": "object",
+       "additionalProperties": {
+         "type": "string",
+         "enum": ["cloud"]
+       },
        "properties": {
-         "cloud": {
-           "type": "string",
-           "enum": ["cloud"]
-         },
-         "android": {
-           "type": "string",
-           "enum": ["cloud"]
-         },
          // ... remove all platform-specific definitions
        }
      }
    }
  }
}

Configuration used: CodeRabbit UI
Review profile: CHILL

{
  "configSchema": {
    "$schema": "http://json-schema.org/draft-07/schema#",
+   "definitions": {
+     "oneTrustCookieCategory": {
+       "type": "array",
+       "items": {
+         "type": "object",
+         "properties": {
+           "oneTrustCookieCategory": {
+             "type": "string",
+             "pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
+           }
+         }
+       }
+     }
+   },
    "properties": {
      "oneTrustCookieCategories": {
        "type": "object",
        "properties": {
-         "cloud": {
-           "type": "array",
-           "items": {
-             "type": "object",
-             "properties": {
-               "oneTrustCookieCategory": {
-                 "type": "string",
-                 "pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
-               }
-             }
-           }
-         },
+         "cloud": { "$ref": "#/definitions/oneTrustCookieCategory" },
+         "android": { "$ref": "#/definitions/oneTrustCookieCategory" },
          // ... repeat for other platforms
        }
      }
    }
  }
}

{
  "configSchema": {
    "definitions": {
+     "consentConfig": {
+       "type": "object",
+       "properties": {
+         "provider": {
+           "type": "string",
+           "enum": ["custom", "ketch", "oneTrust"],
+           "default": "oneTrust"
+         },
+         "consents": {
+           "type": "array",
+           "items": {
+             "type": "object",
+             "properties": {
+               "consent": {
+                 "type": "string",
+                 "pattern": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|^(.{0,100})$"
+               }
+             }
+           }
+         }
+       },
+       "allOf": [
+         {
+           "if": {
+             "properties": {
+               "provider": { "const": "custom" }
+             },
+             "required": ["provider"]
+           },
+           "then": {
+             "properties": {
+               "resolutionStrategy": {
+                 "type": "string",
+                 "enum": ["and", "or"]
+               }
+             },
+             "required": ["resolutionStrategy"]
+           }
+         }
+       ]
+     }
    },
    "properties": {
      "consentManagement": {
        "type": "object",
        "properties": {
-         "cloud": {
-           "type": "array",
-           "items": { ... }
-         },
+         "cloud": { "$ref": "#/definitions/consentConfig" },
+         "android": { "$ref": "#/definitions/consentConfig" },
          // ... repeat for other platforms
        }
      }
    }
  }
}

src/configurations/destinations/accoil_analytics/schema.json (1)

285-795: Consider adding validation for empty consent arrays.

While the conditional logic for resolution strategy is well implemented, consider adding a minimum length requirement for the consents array when a provider is specified. This would prevent configurations with a provider but no actual consents.

Example validation to add (shown for one platform, apply to all):

{
  "if": {
    "properties": {
      "provider": {
        "type": "string"
      }
    },
    "required": ["provider"]
  },
  "then": {
    "properties": {
      "consents": {
        "minItems": 1
      }
    },
    "required": ["consents"]
  }
}

Configuration used: CodeRabbit UI
Review profile: CHILL

Learnt from: accoilmj
PR: rudderlabs/rudder-integrations-config#1807
File: src/configurations/destinations/accoil_analytics/schema.json:148-284
Timestamp: 2024-12-09T04:17:28.675Z
Learning: The file `src/configurations/destinations/accoil_analytics/schema.json` is autogenerated. Avoid suggesting changes to autogenerated files.

Learnt from: accoilmj
PR: rudderlabs/rudder-integrations-config#1807
File: src/configurations/destinations/accoil_analytics/schema.json:285-795
Timestamp: 2024-12-09T04:17:16.931Z
Learning: The file `src/configurations/destinations/accoil_analytics/schema.json` is autogenerated.

Learnt from: accoilmj
PR: rudderlabs/rudder-integrations-config#1807
File: src/configurations/destinations/accoil_analytics/schema.json:11-147
Timestamp: 2024-12-09T04:17:05.013Z
Learning: The file `src/configurations/destinations/accoil_analytics/schema.json` is autogenerated and should not be manually modified.